gh-151096: Fix test_embed with split exec prefix#151288
Open
harjothkhara wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
This is a tests-only change. Could a triager please add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
test_init_is_python_build_with_homefor builds configured with different--prefixand--exec-prefix.When running from the build directory on POSIX, getpath uses
PREFIXforprefix/base_prefixandEXEC_PREFIXforexec_prefix/base_exec_prefix. The test expected both values to matchsys.prefix, which fails for split-prefix builds.This also updates
module_search_paths()so its defaultexec_prefixcomes from the expected config’sexec_prefixinstead ofprefix.Validation:
--prefix=/private/tmp/cpython-151096-install --exec-prefix=/private/tmp/cpython-151096-install/exec../python.exe -m test test_embed -v -m test_init_is_python_build_with_homefailed with mismatchedexec_prefix/base_exec_prefix../python.exe -m test test_embed -v -m test_init_is_python_build_with_homepasses../python.exe -m test test_embed -vpasses.This is a tests-only change; skip news.